Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta targetted Make copy/copy_nonoverlapping fn's again #86203

Merged
merged 7 commits into from
Jun 11, 2021

Conversation

pnkfelix
Copy link
Member

beta backport of PR #86003

to address issue #84297

This is preparation for reverting 81238 for short-term resolution of issue 84297.
…pping`.

Test was added in PR rust-lang#84404.

The intent here is: The `copy`/`copy_overlapping` intrinsics are going through
some flip-flopping now of "are they intrinsics or not". We can achieve the same
effect that the test intended by using `likely`/`unlikely`.
@rust-highfive
Copy link
Collaborator

Some changes occurred in src/tools/clippy.

cc @rust-lang/clippy

@rust-highfive
Copy link
Collaborator

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 10, 2021
@pnkfelix pnkfelix changed the title Beta targetted Make copy/copy_nonoverlapping fn's again [wip] Beta targetted Make copy/copy_nonoverlapping fn's again Jun 10, 2021
@pnkfelix pnkfelix changed the title [wip] Beta targetted Make copy/copy_nonoverlapping fn's again Beta targetted Make copy/copy_nonoverlapping fn's again Jun 11, 2021
@dtolnay
Copy link
Member

dtolnay commented Jun 11, 2021

@bors r+

Approving because #86003 is labelled beta-accepted.

@bors
Copy link
Contributor

bors commented Jun 11, 2021

📌 Commit 61520c8 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2021
@bors
Copy link
Contributor

bors commented Jun 11, 2021

⌛ Testing commit 61520c8 with merge 05f39bf...

@bors
Copy link
Contributor

bors commented Jun 11, 2021

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing 05f39bf to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 11, 2021
@bors bors merged commit 05f39bf into rust-lang:beta Jun 11, 2021
@rustbot rustbot added this to the 1.53.0 milestone Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants